Re: [PATCH] Make some ext3 kernel messages useful by showing device

Andrew Morton
2008-06-09T20:49:38Z

On Mon, 09 Jun 2008 08:43:20 -0500
Eric Sandeen <sandeen@redhat.com> wrote:

> >
> > It is very much preferred, thanks.
> >
> > (patch retained for linux-ext4 review)
>
> The patch itself looks fine to me, and is a good idea. I recently saw a
> confused user on another fs where successful mount messages were
> followed by failure mount messages with no indication of which fs had
> the trouble...
>
> There probably are more spots in extX which could use this treatment...
> should we maybe just be using ext3_warning in more places, which
> automatically prints the sb, function name, etc?

Good point, thanks.