Re: New ext4 patchset 2.6.26-rc8-ext4-1

[Christoph Hellwig <hch@infradead.org>]

On Sat, Jul 05, 2008 at 10:41:15PM -0400, Theodore Tso wrote:
> On Sat, Jul 05, 2008 at 01:50:47PM -0400, Christoph Hellwig wrote:
> > Strong NACK.  For one thing the code added to mpage.c doesn't belong
> > there.  It's far inferior to the existing delalloc code we already have
> > and that could be made generic easily, or the next generation code
> > developed by Chris mason.  It's an ext4-specific hack and doesn't belong
> > into common code.  I'm pretty sure we agreed on not having it in
> > common code long ago.
> 
> Looking back at the mailing list history, yes, we did.  I think the
> reason why we didn't was Andrew had expressed a vague wish that the
> ext4 and xfs developers would get together and try to hash out a
> common layer that all filesystems could work with.  But given that
> nothing has happened in the many months since that discussion, you're
> absolutely right.
> 
> I've reworked the vfs generic patch in the patch series to be much
> smaller --- mainly what's left is simply exporting some mpage
> interfaces that would be needed by ext4.  I trust this is much more to
> your liking?

Yes, this is much better.  But please also add kerneldoc comments for
the newly exported functions.