* [patch 1/4] ext4: error proc entry creation when the fs/ext4 is not correctly created
@ 2008-07-13 6:26 akpm
2008-07-14 1:07 ` Theodore Tso
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-07-13 6:26 UTC (permalink / raw)
To: tytso; +Cc: cmm, linux-ext4, akpm, shen
From: Shen Feng <shen@cn.fujitsu.com>
When the directory fs/ext4 is not correctly created under proc, the entry
under this directory should not be created.
Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/ext4/mballoc.c | 4 ++++
1 file changed, 4 insertions(+)
diff -puN fs/ext4/mballoc.c~ext4-error-proc-entry-creation-when-the-fs-ext4-is-not-correctly-created fs/ext4/mballoc.c
--- a/fs/ext4/mballoc.c~ext4-error-proc-entry-creation-when-the-fs-ext4-is-not-correctly-created
+++ a/fs/ext4/mballoc.c
@@ -2785,6 +2785,10 @@ static int ext4_mb_init_per_dev_proc(str
struct proc_dir_entry *proc;
char devname[64];
+ if (proc_root_ext4 == NULL) {
+ sbi->s_mb_proc = NULL;
+ return -EINVAL;
+ }
bdevname(sb->s_bdev, devname);
sbi->s_mb_proc = proc_mkdir(devname, proc_root_ext4);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/4] ext4: error proc entry creation when the fs/ext4 is not correctly created
2008-07-13 6:26 [patch 1/4] ext4: error proc entry creation when the fs/ext4 is not correctly created akpm
@ 2008-07-14 1:07 ` Theodore Tso
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Tso @ 2008-07-14 1:07 UTC (permalink / raw)
To: akpm; +Cc: cmm, linux-ext4, shen
On Sat, Jul 12, 2008 at 11:26:19PM -0700, akpm@linux-foundation.org wrote:
> From: Shen Feng <shen@cn.fujitsu.com>
>
> When the directory fs/ext4 is not correctly created under proc, the entry
> under this directory should not be created.
>
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-14 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-13 6:26 [patch 1/4] ext4: error proc entry creation when the fs/ext4 is not correctly created akpm
2008-07-14 1:07 ` Theodore Tso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).