From: Theodore Tso <tytso@mit.edu>
To: akpm@linux-foundation.org
Cc: cmm@us.ibm.com, linux-ext4@vger.kernel.org, shen@cn.fujitsu.com
Subject: Re: [patch 2/4] ext4: fix error processing in mb_free_blocks
Date: Sun, 13 Jul 2008 21:07:56 -0400 [thread overview]
Message-ID: <20080714010756.GB7938@mit.edu> (raw)
In-Reply-To: <200807130626.m6D6QKtc007910@imap1.linux-foundation.org>
On Sat, Jul 12, 2008 at 11:26:20PM -0700, akpm@linux-foundation.org wrote:
> From: Shen Feng <shen@cn.fujitsu.com>
>
> The error processing of the return value of mb_free_blocks is meanless
> because it only returns 0. This fix includes
>
> - make mb_free_blocks return void
>
> - remove the error processing part in callers
>
> - unlock group before calling ext4_error in mb_free_blocks
>
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
> Cc: Mingming Cao <cmm@us.ibm.com>
> Cc: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Thanks, applied.
- Ted
prev parent reply other threads:[~2008-07-14 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-13 6:26 [patch 2/4] ext4: fix error processing in mb_free_blocks akpm
2008-07-14 1:07 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080714010756.GB7938@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=shen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox