public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Vegard Nossum" <vegard.nossum@gmail.com>
Cc: linux-ext4@vger.kernel.org, sct@redhat.com, adilger@sun.com,
	"Ingo Molnar" <mingo@elte.hu>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: latest -git: A peculiar case of a stuck process (ext3/sched-related?)
Date: Fri, 18 Jul 2008 03:32:25 -0700	[thread overview]
Message-ID: <20080718033225.c141978c.akpm@linux-foundation.org> (raw)
In-Reply-To: <19f34abd0807180317g40a218a2p2bb2857c6f5aa659@mail.gmail.com>

On Fri, 18 Jul 2008 12:17:17 +0200 "Vegard Nossum" <vegard.nossum@gmail.com> wrote:

> And the ext3_find_entry() corresponds to this line:
> 
>         for (; de < top; de = ext3_next_entry(de)) /* <--- HERE! */
>         if (ext3_match (namelen, name, de)) {
>                 if (!ext3_check_dir_entry("ext3_find_entry",
>                                           dir, de, bh,
>                           (block<<EXT3_BLOCK_SIZE_BITS(sb))
>                                   +((char *)de - bh->b_data))) {
>                         brelse (bh);
>                         *err = ERR_BAD_DX_DIR;
>                         goto errout;
>                 }
>                 *res_dir = de;
>                 dx_release (frames);
>                 return bh;
>         }
> 
> Is it possible that this loop can get stuck with a corrupt filesystem image?

yup.  ext2 did that a couple of times.  See the explicit check for
de->rec_len == 0 in ext2_find_entry().

We fixed one filesystem and forgot the others.  Again.

  reply	other threads:[~2008-07-18 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18  9:45 latest -git: A peculiar case of a stuck process (ext3/sched-related?) Vegard Nossum
2008-07-18 10:17 ` Vegard Nossum
2008-07-18 10:32   ` Andrew Morton [this message]
2008-07-18 10:39     ` Vegard Nossum
2008-07-18 13:00   ` Duane Griffin
2008-07-18 17:05     ` Vegard Nossum
2008-07-18 19:59       ` Duane Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718033225.c141978c.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adilger@sun.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sct@redhat.com \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox