Re: [PATCH 1/2] sync up block & inode bitmap reading functions

[Andreas Dilger <adilger@sun.com>]

On Jul 18, 2008  14:52 -0500, Eric Sandeen wrote:
> @@ -97,34 +97,41 @@ unsigned ext4_init_inode_bitmap(struct s
>  static struct buffer_head *
> -read_inode_bitmap(struct super_block *sb, ext4_group_t block_group)
> +ext4_read_inode_bitmap(struct super_block *sb, ext4_group_t block_group)
>  {
>  	struct ext4_group_desc *desc;
>  	struct buffer_head *bh = NULL;
> +	ext4_fsblk_t bitmap_blk;
>  
>  	desc = ext4_get_group_desc(sb, block_group, NULL);
>  	if (!desc)
> +		return NULL;

If you were feeling generous, you could change this function to take
gdp as a parameter (or post it as a kernel janitor task?), because
it is already available in most of the functions that call
read_{block,inode}_bitmap(), with the exception of ext4_orphan_get().

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.