linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: ext4 <linux-ext4@vger.kernel.org>
Subject: Re: i_size error with the latest patchqueue
Date: Thu, 31 Jul 2008 12:47:28 -0400	[thread overview]
Message-ID: <20080731164728.GF11632@mit.edu> (raw)
In-Reply-To: <20080731161058.GA20838@skywalker>

On Thu, Jul 31, 2008 at 09:40:59PM +0530, Aneesh Kumar K.V wrote:
> Hi Ted,
> 
> I haven't yet looked at whether it is kernel or e2fsck bug.
> But I am having this with the latest patch queue when running
> fsstress. The fsstress have falloc added as a supported operation.
> So it is mostly to do with fallocate. Architecture is x86.

Part of this is definitely an e2fsck bug, because e2fsck isn't
currently checking the EXT2_EXTENT_FLAGS_UNINIT flag.  In line 1715 of
e2fsck/pass1.c:

	start_block = pb->last_block = extent.e_lblk + extent.e_len - 1;

We shouldn't be setting pb->last_block if this is an unitialized
extent.

I suspect this is also related though to the issue you raised in the
"e2fsprogs and blocks outside i_size" thread about two weeks ago.  So
even after we fix this e2fsck bug, we may still have some fsstress
failures until we decide how to deal with that particular issue.

Do you have a quickie program that calls fallocate to preallocate
space for a particular program easily to hand?  If not, I can write
one in about 5-10 minutes, but if you have one written already, it'll
save me the effort.  Thanks!!

						- Ted

  parent reply	other threads:[~2008-07-31 16:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31 16:10 i_size error with the latest patchqueue Aneesh Kumar K.V
2008-07-31 16:41 ` Eric Sandeen
2008-07-31 17:06   ` Aneesh Kumar K.V
2008-07-31 16:47 ` Theodore Tso [this message]
2008-07-31 16:51   ` Eric Sandeen
2008-07-31 16:59   ` Aneesh Kumar K.V
2008-07-31 17:08   ` Aneesh Kumar K.V
2008-07-31 18:25     ` Theodore Tso
2008-07-31 18:47       ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080731164728.GF11632@mit.edu \
    --to=tytso@mit.edu \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).