Re: i_size error with the latest patchqueue

[Theodore Tso <tytso@mit.edu>]

On Thu, Jul 31, 2008 at 10:38:56PM +0530, Aneesh Kumar K.V wrote:
> 
> Also note that fallocate is called with update i_size option.
> 

Are you sure about this?  I can replicate the problem using Eric's
fallocate problem if i_size is not updated:

<tytso.root@closure> {/tmp}, level 2  
509# touch /mnt/foo
<tytso.root@closure> {/tmp}, level 2  
510# ./fallocate -n  -l 10m /mnt/foo
<tytso.root@closure> {/tmp}, level 2  
511# ls -al /mnt/foo
10240 -rw-r--r-- 1 root root 0 2008-07-31 14:24 /mnt/foo
<tytso.root@closure> {/tmp}, level 2  
512# umount /mnt
<tytso.root@closure> {/tmp}, level 2  
513# e2fsck -fy /dev/thunk/testext4
e2fsck 1.41.0 (10-Jul-2008)
Pass 1: Checking inodes, blocks, and sizes
Inode 12, i_size is 0, should be 10485760.  Fix? yes

Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
Pass 5: Checking group summary information

/dev/thunk/testext4: ***** FILE SYSTEM WAS MODIFIED *****
/dev/thunk/testext4: 12/65536 files (16.7% non-contiguous), 15205/262144 blocks

  	      	    	   		    		 - Ted