From: Theodore Tso <tytso@mit.edu>
To: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
sugita <yumiko.sugita.yf@hitachi.com>,
Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>
Subject: Re: [PATCH] jbd2: don't abort if flushing file data failed
Date: Thu, 31 Jul 2008 22:33:59 -0400 [thread overview]
Message-ID: <20080801023358.GC8736@mit.edu> (raw)
In-Reply-To: <48915500.3050500@hitachi.com>
On Thu, Jul 31, 2008 at 03:00:32PM +0900, Hidehiro Kawai wrote:
> I tested this patch on 2.6.27-rc1, but it didn't work properly.
> Then, I noticed two mistakes.
>
> (1) journal_submit_data_buffers() just submits I/Os, doesn't wait
> their completion. We have to check file data write errors
> after calling journal_finish_inode_data_buffers()
> (2) AS_EIO is cleared by wait_on_page_writeback_range(), so we
> have to set it again
Thank you very much for catching these errors; you are very correct!
> I attached the revised patch below. journal_submit_data_buffers()
> can return error, but it wouldn't be write I/O error AFAIK, so I
> didn't touched.
I've replaced the patch with your revised patch in the ext4 patch
queue; thanks again for double-checking the patch and offering the
revised version.
Many thanks,
- Ted
prev parent reply other threads:[~2008-08-01 2:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-27 0:26 [PATCH] ext4: Cleanup whitespace and other miscellaneous style issues Theodore Ts'o
2008-07-27 0:26 ` [PATCH] ext4: don't read inode block if the buffer has a write error Theodore Ts'o
2008-07-27 0:26 ` [PATCH] ext4: unexport jbd2_journal_update_superblock Theodore Ts'o
2008-07-27 0:26 ` [PATCH] jbd2: don't abort if flushing file data failed Theodore Ts'o
2008-07-29 5:53 ` Hidehiro Kawai
2008-07-29 12:35 ` Theodore Tso
2008-07-31 6:00 ` Hidehiro Kawai
2008-08-01 2:33 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080801023358.GC8736@mit.edu \
--to=tytso@mit.edu \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-ext4@vger.kernel.org \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).