From: Theodore Tso <tytso@mit.edu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3] ext4: add EXT4_IOC_GETCRTIME ioctl
Date: Sat, 9 Aug 2008 22:26:43 -0400 [thread overview]
Message-ID: <20080810022643.GC14756@mit.edu> (raw)
In-Reply-To: <48996A33.3010507@cn.fujitsu.com>
On Wed, Aug 06, 2008 at 05:09:07PM +0800, Li Zefan wrote:
> + case EXT4_IOC_GETCRTIME:
> + return put_user(ei->i_crtime, (struct timespec __user *)arg);
> +
I'm worried about writing a struct timespec directly to user space,
because the kernel's idea of what is struct timespec might not be the
same as the userspace's understanding of struct timespec ---
specifically, because of the question of the width of time_t might be
different in the kernel and in userspace on different architectures.
I think we would be better off explicitly defining a structure, or
just returning the seconds and nanoseconds in explicit primitive
types.
Regards,
- Ted
next prev parent reply other threads:[~2008-08-10 3:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 9:09 [PATCH 1/3] ext4: add EXT4_IOC_GETCRTIME ioctl Li Zefan
2008-08-10 2:26 ` Theodore Tso [this message]
2008-08-18 2:08 ` Li Zefan
2008-08-18 2:36 ` Theodore Tso
2008-08-18 9:01 ` Andreas Dilger
2008-08-18 10:03 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080810022643.GC14756@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).