Re: Oops with ext4 from 2.6.27-rc3

Mingming Cao
2008-08-14T14:58:45Z

在 2008-08-14四的 08:59 +0200，Christian Hesse写道：
> On Thursday 14 August 2008, Theodore Tso wrote:
> > On Wed, Aug 13, 2008 at 05:10:53PM -0700, Mingming Cao wrote:
> > > I could reproduce it.
> > >
> > > This patch works for me on top of Ted's change. Christian, could you
> > > try it?
> >
> > Thanks, mingming! Looks good and I've added it to the patch queue.
>
> 08:58:16 eworm@io:~$ uptime
> 08:58:18 up 37 min, 2 users, load average: 3.57, 2.36, 1.12
>
> This is *a lot* longer than the system survived without the patches. I hope it
> is fixed now. Ted and Mingming, thanks a lot!
>
> A short side note... I get warnings when compiling the new code:
>
> fs/ext4/inode.c: In function 'ext4_da_release_space':
> fs/ext4/inode.c:1581: warning: format '%d' expects type 'int', but argument 2
> has type 'long unsigned int'
> fs/ext4/inode.c:1581: warning: format '%lu' expects type 'long unsigned int',
> but argument 3 has type 'int'

Thanks to all for quick verification of the fix.

Here is the fix for the compile warning . This compile warning fix has
be fold to the parent patch in ext4 patch queue :
fix-delalloc-release-block-reservation-for-truncate

http://repo.or.cz/w/ext4-patch-queue.git

Thanks,
Ming,ming

Index: linux-2.6.27-rc3/fs/ext4/inode.c
===================================================================
--- linux-2.6.27-rc3.orig/fs/ext4/inode.c 2008-08-14 07:49:14.000000000 -0700
+++ linux-2.6.27-rc3/fs/ext4/inode.c 2008-08-14 07:49:45.000000000 -0700
@@ -1576,7 +1576,7 @@ static void ext4_da_release_space(struct
*/
printk(KERN_INFO "ext4 delalloc try to release %d reserved"
"blocks for inode %lu, but there is no reserved"
- "data blocks\n", inode->i_ino, to_free);
+ "data blocks\n", to_free, inode->i_ino);
spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
return;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html