From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Theodore Tso <tytso@mit.edu>
Cc: cmm@us.ibm.com, sandeen@redhat.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix small file fragmentation
Date: Fri, 15 Aug 2008 22:03:01 +0530 [thread overview]
Message-ID: <20080815163301.GB6511@skywalker> (raw)
In-Reply-To: <20080815163112.GA6511@skywalker>
On Fri, Aug 15, 2008 at 10:01:12PM +0530, Aneesh Kumar K.V wrote:
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 25adfc3..a658690 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -163,7 +163,9 @@ void __mark_inode_dirty(struct inode *inode, int flags)
> */
> if (!was_dirty) {
> inode->dirtied_when = jiffies;
> - list_move(&inode->i_list, &sb->s_dirty);
> + //list_move(&inode->i_list, &sb->s_dirty);
> + __list_del(&inode->i_list->prev, &inode->i_list->next);
> + list_add_tail(&inode->i_list, &sb->s_dirty);
> }
> }
> out:
better one
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 25adfc3..91f3c54 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -163,7 +163,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
*/
if (!was_dirty) {
inode->dirtied_when = jiffies;
- list_move(&inode->i_list, &sb->s_dirty);
+ list_move_tail(&inode->i_list, &sb->s_dirty);
}
}
out:
next prev parent reply other threads:[~2008-08-15 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 17:44 [PATCH] ext4: Fix small file fragmentation Aneesh Kumar K.V
2008-08-14 22:16 ` Mingming Cao
[not found] ` <20080814231816.GA13048@mit.edu>
2008-08-15 13:38 ` Theodore Tso
2008-08-15 16:31 ` Aneesh Kumar K.V
2008-08-15 16:33 ` Aneesh Kumar K.V [this message]
2008-08-15 17:52 ` Aneesh Kumar K.V
2008-08-15 18:07 ` Aneesh Kumar K.V
2008-08-15 20:05 ` Theodore Tso
2008-08-16 4:43 ` Aneesh Kumar K.V
2008-08-16 10:43 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080815163301.GB6511@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox