Patches for patch queue

Patches for patch queue

[Aneesh Kumar K.V]

Hi,

Can we get the below patches in patch queue.


http://www.radian.org/~kvaneesh/ext4/patch-series/ext-truncate-mutex.patch
http://www.radian.org/~kvaneesh/ext4/patch-series/ext3-4-migrate.patch
http://www.radian.org/~kvaneesh/ext4/patch-series/new-extent-function.patch
http://www.radian.org/~kvaneesh/ext4/patch-series/mballoc-core.patch
http://www.radian.org/~kvaneesh/ext4/patch-series/mballoc-fixup.patch



# This series applies on GIT commit 39d3520c92cf7a28c07229ca00cc35a1e8026c77
ext4-journal_chksum-2.6.20.patch
ext4-journal-chksum-review-fix.patch
64-bit-i_version.patch
i_version_hi.patch
ext4_i_version_hi_2.patch
i_version_update_ext4.patch
jbd-stats-through-procfs
jbd-stats-through-procfs_fix.patch
delalloc-vfs.patch
delalloc-ext4.patch
ext-truncate-mutex.patch
ext3-4-migrate.patch
new-extent-function.patch
mballoc-core.patch
mballoc-fixup.patch


I have added then towards the end of the series based on the comment from Alex
that mballoc need further cleanup and he likes to finish with delayed allocation first.


-aneesh 

Re: Patches for patch queue

[Dave Kleikamp]

On Thu, 2007-08-16 at 12:48 +0530, Aneesh Kumar K.V wrote:
> Hi,
> 
> Can we get the below patches in patch queue.
> 
> 
> http://www.radian.org/~kvaneesh/ext4/patch-series/ext-truncate-mutex.patch
> http://www.radian.org/~kvaneesh/ext4/patch-series/ext3-4-migrate.patch
> http://www.radian.org/~kvaneesh/ext4/patch-series/new-extent-function.patch
> http://www.radian.org/~kvaneesh/ext4/patch-series/mballoc-core.patch
> http://www.radian.org/~kvaneesh/ext4/patch-series/mballoc-fixup.patch

scripts/checkpatch.pl spits out a lot of warnings against these patches.
Do you think you can clean them up first?

Thanks,
Shaggy

> # This series applies on GIT commit 39d3520c92cf7a28c07229ca00cc35a1e8026c77
> ext4-journal_chksum-2.6.20.patch
> ext4-journal-chksum-review-fix.patch
> 64-bit-i_version.patch
> i_version_hi.patch
> ext4_i_version_hi_2.patch
> i_version_update_ext4.patch
> jbd-stats-through-procfs
> jbd-stats-through-procfs_fix.patch
> delalloc-vfs.patch
> delalloc-ext4.patch
> ext-truncate-mutex.patch
> ext3-4-migrate.patch
> new-extent-function.patch
> mballoc-core.patch
> mballoc-fixup.patch
> 
> 
> I have added then towards the end of the series based on the comment from Alex
> that mballoc need further cleanup and he likes to finish with delayed allocation first.
> 
> 
> -aneesh 
-- 
David Kleikamp
IBM Linux Technology Center

Re: Patches for patch queue

[Dave Kleikamp]

On Thu, 2007-08-16 at 10:45 -0500, Dave Kleikamp wrote:
> On Thu, 2007-08-16 at 12:48 +0530, Aneesh Kumar K.V wrote:
> > Hi,
> > 
> > Can we get the below patches in patch queue.
> > 
> > 
> > http://www.radian.org/~kvaneesh/ext4/patch-series/ext-truncate-mutex.patch
> > http://www.radian.org/~kvaneesh/ext4/patch-series/ext3-4-migrate.patch
> > http://www.radian.org/~kvaneesh/ext4/patch-series/new-extent-function.patch
> > http://www.radian.org/~kvaneesh/ext4/patch-series/mballoc-core.patch
> > http://www.radian.org/~kvaneesh/ext4/patch-series/mballoc-fixup.patch
> 
> scripts/checkpatch.pl spits out a lot of warnings against these patches.
> Do you think you can clean them up first?

As we discussed, I checked these into the patch queue.  That way they
can be more easily tested in the short term.

Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

Patches for patch queue

[Aneesh Kumar K.V]

Hi Mingming,

Some update for patches in the patch queue. I am sending it as a diff
against patch queue so that it makes it easier to apply
The first hunk is a missed return 0 as a part of patch
ext4_invalidate_pages_when_delalloc_alloc_fail.patch

diff --git a/ext4_invalidate_pages_when_delalloc_alloc_fail.patch b/ext4_invalidate_pages_when_delalloc_alloc_fail.patch
index f0722ab..d47d3bf 100644
--- a/ext4_invalidate_pages_when_delalloc_alloc_fail.patch
+++ b/ext4_invalidate_pages_when_delalloc_alloc_fail.patch
@@ -92,7 +92,7 @@ Index: linux-2.6.27-rc3/fs/ext4/inode.c
 +		 * will find the dirty page again
 +		 */
 +		if (err == -EAGAIN)
-+			return;
++			return 0;
 +		/*
 +		 * get block failure will cause us
 +		 * to loop in writepages. Because
diff --git a/fix-delalloc-release-block-reservation-for-truncate b/fix-delalloc-release-block-reservation-for-truncate
index 8dc891b..32f1063 100644
--- a/fix-delalloc-release-block-reservation-for-truncate
+++ b/fix-delalloc-release-block-reservation-for-truncate
@@ -48,8 +48,8 @@ Index: linux-2.6.27-rc3/fs/ext4/inode.c
 +		 * but since this function is called from invalidate
 +		 * page, it's harmless to return without any action
 +		 */
-+		printk(KERN_INFO "ext4 delalloc try to release %d reserved"
-+			    "blocks for inode %lu, but there is no reserved"
++		printk(KERN_INFO "ext4 delalloc try to release %d reserved "
++			    "blocks for inode %lu, but there is no reserved "
 +			    "data blocks\n", to_free, inode->i_ino);
 +		spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
 +		return;