From: Matthew Wilcox <matthew@wil.cx>
To: Josef Bacik <jbacik@redhat.com>
Cc: linux-kernel@vger.kernel.org, rwheeler@redhat.com,
tglx@linutronix.de, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] add hrtimer_sleep_ns helper function
Date: Tue, 19 Aug 2008 13:15:08 -0600 [thread overview]
Message-ID: <20080819191508.GD8318@parisc-linux.org> (raw)
In-Reply-To: <20080806190819.GH27394@unused.rdu.redhat.com>
On Wed, Aug 06, 2008 at 03:08:19PM -0400, Josef Bacik wrote:
> -static int __sched do_nanosleep(struct hrtimer_sleeper *t, enum hrtimer_mode mode)
> +static int __sched do_nanosleep(struct hrtimer_sleeper *t, enum hrtimer_mode mode,
> + int interruptible)
> {
> hrtimer_init_sleeper(t, current);
>
> do {
> - set_current_state(TASK_INTERRUPTIBLE);
> + set_current_state(interruptible ? TASK_INTERRUPTIBLE :
> + TASK_UNINTERRUPTIBLE);
I don't see any users (in this patch or the next) of people wanting
uninterruptible nanosleeps. We shouldn't be introducing new
TASK_UNINTERRUPTIBLE users, but instead using TASK_KILLABLE if the user
really can't cope with signals in a sensible manner.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-08-19 19:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 19:08 [PATCH 1/2] add hrtimer_sleep_ns helper function Josef Bacik
2008-08-06 19:15 ` [PATCH 2/2] improve ext3 fsync batching Josef Bacik
2008-08-06 19:23 ` Josef Bacik
2008-08-19 4:31 ` Andrew Morton
2008-08-19 5:44 ` Andreas Dilger
2008-08-19 11:01 ` Ric Wheeler
2008-08-19 17:56 ` Andrew Morton
2008-08-19 18:08 ` Ric Wheeler
2008-08-19 20:29 ` Andrew Morton
2008-08-19 20:55 ` Ric Wheeler
2008-08-19 21:18 ` Andrew Morton
2008-08-19 21:29 ` Ric Wheeler
2008-08-19 18:43 ` Ric Wheeler
2008-08-19 20:34 ` Andrew Morton
2008-08-19 19:18 ` Josef Bacik
2008-08-19 19:15 ` Matthew Wilcox [this message]
2008-08-19 19:22 ` [PATCH 1/2] add hrtimer_sleep_ns helper function Josef Bacik
2008-08-19 19:36 ` Matthew Wilcox
2008-08-19 19:39 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819191508.GD8318@parisc-linux.org \
--to=matthew@wil.cx \
--cc=chris.mason@oracle.com \
--cc=jbacik@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).