Re: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully

Ralf Hildebrandt
2008-09-07T16:10:03Z

* Alexey Dobriyan <adobriyan@gmail.com>:

> > Why not use strchr(), which is normally optimized assembly:
> >
> > char *p = devname;
> > while ((p = strchr(p, '/'))
> > *p = '_';
> >
> > Using '!' as the separator makes it harder to use from shells I suspect,
> > so I'd suggest '_' instead.
>
> bdevname is only 32 bytes and done once per mount, so nobody cares.
>
> '!' is what other code does in this situation (reiserfs, md, ...).

Anyway, the first patch fixes the issue. Will it go into mainline soon?

--
Ralf Hildebrandt (i.A. des IT-Zentrums) Ralf.Hildebrandt@charite.de
Charite - Universitätsmedizin Berlin Tel. +49 (0)30-450 570-155
Gemeinsame Einrichtung von FU- und HU-Berlin Fax. +49 (0)30-450 570-962
IT-Zentrum Standort CBF I'm looking for a job!
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html