public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@MIT.EDU>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] make all feature-related printks KERN_INFO and print barrier status as well
Date: Mon, 8 Sep 2008 17:10:47 -0400	[thread overview]
Message-ID: <20080908211047.GN8161@mit.edu> (raw)
In-Reply-To: <48C55C0E.2050809@redhat.com>

On Mon, Sep 08, 2008 at 12:08:30PM -0500, Eric Sandeen wrote:
> A very trivial little tidy-up patch.
> 
> This slightly duplicates a little of
> patches/ext4_fix_printk_checkpatch_issues but just in one hunk,
> easily fixed up.
> 
> Various feature printk's come out at different levels, so for example
> at my default logging level I see mballoc & extents messages, but
> not delalloc, even though they are all on.
> 
> Also, since default barrier behavior has changed, I thought perhaps always
> printing the barrier state might be a good idea.

Looks good to me.  Any reason not to merge it with the
ext4_fix_printk_checkpatches_issues?  Actually what I was thinking
about doing was to segregate out all of the printk level issues from
everything else, just to make it easier to understand/audit the
cleanup patch(es).

							- Ted

  reply	other threads:[~2008-09-08 21:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08 17:08 [PATCH] make all feature-related printks KERN_INFO and print barrier status as well Eric Sandeen
2008-09-08 21:10 ` Theodore Tso [this message]
2008-09-08 21:20   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080908211047.GN8161@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox