Re: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully

Theodore Tso
2008-09-07T16:25:04Z

On Sun, Sep 07, 2008 at 04:15:57PM +0400, Alexey Dobriyan wrote:
> > Why not use strchr(), which is normally optimized assembly:
> >
> > char *p = devname;
> > while ((p = strchr(p, '/'))
> > *p = '_';
> >
> > Using '!' as the separator makes it harder to use from shells I suspect,
> > so I'd suggest '_' instead.
>
> bdevname is only 32 bytes and done once per mount, so nobody cares.

Bloat gets inserted into the kernel, 32 bytes at a time. :-)

> '!' is what other code does in this situation (reiserfs, md, ...).

I'm not convinced that the consistency is as important in this case as
making it easy for people using shells typing the pathname...

On Sun, Sep 07, 2008 at 06:04:14PM +0200, Ralf Hildebrandt wrote:
>
> Anyway, the first patch fixes the issue. Will it go into mainline soon?
>

I'll queue the patch (with fixups) for the 2.6.27 merge window. This
isn't a regression, and it's getting rather late in the 2.6.27-rc
series. I've bent the rules about submitting non-regression bug fixes
back when most ext4 users were testers or developers; but now that we
are getting real users, and Linus has started yelling at developers
for ignoring the merge window rules, I'm going to be much more of a
stickler about only pushing regression bug-fixes after the merge
window closes.

- Ted