From: Karel Zak <kzak@redhat.com>
To: Andreas Dilger <adilger@sun.com>
Cc: Theodore Tso <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] libblki: fix s_feature_compat usage
Date: Tue, 16 Sep 2008 01:36:43 +0200 [thread overview]
Message-ID: <20080915233643.GA5617@nb.net.home> (raw)
In-Reply-To: <20080915231102.GE3241@webber.adilger.int>
On Mon, Sep 15, 2008 at 04:11:02PM -0700, Andreas Dilger wrote:
> On Sep 15, 2008 14:03 +0200, Karel Zak wrote:
> > Note that this patch also fix minor coding still errors.
oops, s/still/style/ :-(
> > @@ -150,7 +150,7 @@ static void get_ext2_info(blkid_dev dev, struct blkid_magic *id,
> >
> > set_uuid(dev, es->s_uuid, 0);
> >
> > - if ((es->s_feature_compat & EXT3_FEATURE_COMPAT_HAS_JOURNAL) &&
> > + if ((blkid_le32(es->s_feature_compat) & EXT3_FEATURE_COMPAT_HAS_JOURNAL) &&
>
> Minor note - it is generally preferable to swab the constant value,
probably yes, but see the rest of the library code... :-)
Karel
--
Karel Zak <kzak@redhat.com>
prev parent reply other threads:[~2008-09-15 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 12:03 [PATCH] libblki: fix s_feature_compat usage Karel Zak
2008-09-15 23:11 ` Andreas Dilger
2008-09-15 23:36 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080915233643.GA5617@nb.net.home \
--to=kzak@redhat.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).