Re: [PATCH 1/4] vfs: vfs-level fiemap interface

Andreas Dilger
2008-09-16T06:49:55Z

On Sep 15, 2008 10:47 -0400, Christoph Hellwig wrote:
> Again, I'd love it when people would read my mails :( Can we please
> first agree on what the flag is actually supposed to mean? I made one
> guess in this mail, but I'm not sure if that's even what Andreas
> intended. And of course the description for it is even more important
> than the name.

The intent of this flag was a "catch-all" to indicate it isn't safe
to try and read this block from disk, either because it is encrypted,
compressed, on a remote system (HSM or over a network), or maybe not
even written to disk yet (delalloc).

In some cases (e.g. dump on a snapshot, or boot with LILO) it IS ok to
read directly from a block device underneath the filesystem, but that
would completely fail for the above cases.

Note that the NO_BYPASS (formerly NO_DIRECT) flag is meant to be used
in conjunction with other flags that specify more clearly the reason
that this block is not directly accessible. Having a "generic" flag
cover these different flag allows simple applications to know whether
the block is readable or not, without having to understand each flag
itself, and allows the flags to be expanded in the future (e.g. HSM or
whatever that doesn't get included right away).

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.