From: Theodore Tso <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: akpm@linux-foundation.org,
Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext3/jbd: Avoid WARN() messages when failing to write to the superblock
Date: Sun, 21 Sep 2008 22:51:29 -0400 [thread overview]
Message-ID: <20080922025129.GB9914@mit.edu> (raw)
In-Reply-To: <20080921173328.GB23547@atrey.karlin.mff.cuni.cz>
On Sun, Sep 21, 2008 at 07:33:28PM +0200, Jan Kara wrote:
> > This fixes some very common warnings reported by kerneloops.org
> >
> > Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> The patch looks nice but does it really fix the warnings? I see
> at least ext3_put_super() calling mark_buffer_dirty() before calling
> ext3_commit_super(). We should just remove that mark_buffer_dirty()
> call.
I tested it, and in practice it works, since mark_buffer_dirty() only
causes a problem if an attempt to write to the superblock has already
failed. I agree that we should just remove that mark_buffer_dirty()
call, though, since ext3_put_super() calls ext3_commit_super() which
calls mark_buffer_dirty() anyway. I'll respin the patch.
> BTW: Do you plan doing a similar fix for ext2 and ext4?
I have a similar fix for ext4 that is queued up to be pushed once the
merge window opens. I haven't back-ported it to ext2 yet, but I will.
- Ted
prev parent reply other threads:[~2008-09-22 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-20 21:35 [PATCH] ext3/jbd: Avoid WARN() messages when failing to write to the superblock Theodore Ts'o
2008-09-21 2:14 ` Arjan van de Ven
2008-09-21 17:33 ` Jan Kara
2008-09-22 2:51 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922025129.GB9914@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox