linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, akpm@linux-foundation.org,
	adobriyan@gmail.com, adilger@sun.com,
	ralf.hildebrandt@charite.de
Subject: [patch for 2.6.27? 1/1] ext4: create /proc/ext4/*/stats et al more carefully
Date: Mon, 22 Sep 2008 14:07:06 -0700	[thread overview]
Message-ID: <200809222107.m8ML76xD029671@imap1.linux-foundation.org> (raw)

From: Alexey Dobriyan <adobriyan@gmail.com>

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11321

ext4 creates per-suberblock directory in /proc/ext4/ .  Name used as basis
is taken from bdevname, which, surprise, can contain slash.

However, proc while allowing to use proc_create("a/b", parent) form of
PDE creation, assumes that parent/a was already created.

bdevname in question is 'cciss/c0d0p9', directory is not created and all
this stuff goes directly into /proc (which is real bug).

Warning comes when _second_ partition is mounted.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Reported-by: Ralf Hildebrandt <ralf.hildebrandt@charite.de>
Tested-by: Ralf Hildebrandt <ralf.hildebrandt@charite.de>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/ext4/mballoc.c |    9 +++++++++
 1 file changed, 9 insertions(+)

diff -puN fs/ext4/mballoc.c~ext4-fix-11321-create-proc-ext4-stats-et-al-more-carefully fs/ext4/mballoc.c
--- a/fs/ext4/mballoc.c~ext4-fix-11321-create-proc-ext4-stats-et-al-more-carefully
+++ a/fs/ext4/mballoc.c
@@ -2792,6 +2792,15 @@ static int ext4_mb_init_per_dev_proc(str
 		return -EINVAL;
 	}
 	bdevname(sb->s_bdev, devname);
+	{
+		char *p = devname;
+
+		while (*p != '\0') {
+			if (*p == '/')
+				*p = '!';
+			p++;
+		}
+	}
 	sbi->s_mb_proc = proc_mkdir(devname, proc_root_ext4);
 
 	MB_PROC_HANDLER(EXT4_MB_STATS_NAME, stats);
_

                 reply	other threads:[~2008-09-22 21:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809222107.m8ML76xD029671@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adilger@sun.com \
    --cc=adobriyan@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ralf.hildebrandt@charite.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).