linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] debugfs : Fix usage of logdump command to make consistent with man page.
@ 2008-09-12  8:39 Manish Katiyar
  2008-10-01 23:56 ` Theodore Tso
  0 siblings, 1 reply; 2+ messages in thread
From: Manish Katiyar @ 2008-09-12  8:39 UTC (permalink / raw)
  To: linux-ext4, Theodore Tso; +Cc: mkatiyar

Below path adds the missing 's' option in the usage of logdump. Also
trivially replace "inode" with "filespec" to make consistent with man
page.


Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>

---
 debugfs/logdump.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debugfs/logdump.c b/debugfs/logdump.c
index fed9838..73680de 100644
--- a/debugfs/logdump.c
+++ b/debugfs/logdump.c
@@ -88,7 +88,7 @@ void do_logdump(int argc, char **argv)
 	struct journal_source journal_source;
 	struct ext2_super_block *es = NULL;

-	journal_source.where = 0;
+	journal_source.where = JOURNAL_IS_INTERNAL;
 	journal_source.fd = 0;
 	journal_source.file = 0;
 	dump_all = 0;
@@ -264,7 +264,7 @@ errout:
 	return;

 print_usage:
-	fprintf(stderr, "%s: Usage: logdump [-ac] [-b<block>] [-i<inode>]\n\t"
+	fprintf(stderr, "%s: Usage: logdump [-acs] [-b<block>] [-i<filespec>]\n\t"
 		"[-f<journal_file>] [output_file]\n", argv[0]);
 }

-- 
1.5.4.3


Thanks -
Manish

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] debugfs : Fix usage of logdump command to make consistent with man page.
  2008-09-12  8:39 [PATCH] debugfs : Fix usage of logdump command to make consistent with man page Manish Katiyar
@ 2008-10-01 23:56 ` Theodore Tso
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Tso @ 2008-10-01 23:56 UTC (permalink / raw)
  To: Manish Katiyar; +Cc: linux-ext4

On Fri, Sep 12, 2008 at 02:09:19PM +0530, Manish Katiyar wrote:
> Below path adds the missing 's' option in the usage of logdump. Also
> trivially replace "inode" with "filespec" to make consistent with man
> page.

Thanks, applied.

						- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-01 23:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-12  8:39 [PATCH] debugfs : Fix usage of logdump command to make consistent with man page Manish Katiyar
2008-10-01 23:56 ` Theodore Tso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).