From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH, RFC] percpu_counters: make fbc->count read atomic on 32 bit architecture
Date: Tue, 7 Oct 2008 11:04:07 -0700 [thread overview]
Message-ID: <20081007110407.f22b92e1.akpm@linux-foundation.org> (raw)
In-Reply-To: <1223373347.26330.19.camel@lappy.programming.kicks-ass.net>
On Tue, 07 Oct 2008 11:55:47 +0200 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Mon, 2008-10-06 at 23:23 -0700, Andrew Morton wrote:
> > On Sun, 05 Oct 2008 21:28:10 -0400 "Theodore Ts'o" <tytso@mit.edu> wrote:
> >
> > > The following patch has been sitting in the ext4 patch queue for about
> > > six weeks. It was there it was a suspected cause for block allocation
> > > bug. As I recall, it we found the true root cause since then, but this
> > > has stuck around since it's a potential problem. Andrew has expressed
> > > concerns that this patch might have performance impacts.
> >
> > Performace impacts I guess we'll just have to put up with. iirc I was
> > thinking that this implementation should be pushed down to a kernel-wide
> > atomic64_t and then the percpu_counters would just use that type.
>
> something like so?
We should think about and document the contexts in which these things
can be used. Possibly add runtime checks too. afaict they shouldn't be used in
hard IRQs, and that's pretty unusual for an atomic type.
prev parent reply other threads:[~2008-10-07 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1KmetO-00053M-5u@closure.thunk.org>
2008-10-07 6:23 ` [PATCH, RFC] percpu_counters: make fbc->count read atomic on 32 bit architecture Andrew Morton
2008-10-07 9:55 ` Peter Zijlstra
2008-10-07 17:09 ` richard kennedy
2008-10-07 17:22 ` Peter Zijlstra
2008-10-07 18:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081007110407.f22b92e1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).