From: Theodore Tso <tytso@mit.edu>
To: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
adilger@sun.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
jack@suse.cz
Subject: Re: [PATCH 4/4] jbd2: don't dirty original metadata buffer on abort
Date: Mon, 13 Oct 2008 22:58:14 -0400 [thread overview]
Message-ID: <20081014025814.GB9332@mit.edu> (raw)
In-Reply-To: <20081013203641.GA6469@mail.oracle.com>
On Mon, Oct 13, 2008 at 01:36:42PM -0700, Joel Becker wrote:
> > This patch prevents original metadata buffers from being dirtied
> > on abort by clearing BH_JBDDirty flag from those buffers. Thus,
> > no metadata buffers are written to the filesystem without journaling.
>
> It's not my place to Ack such patches, but I noticed this bug
> during Plumbers, and Eric and Andreas pointed me to this patch, which
> fixes it quite nicely. Just $0.02 :-)
Already pushed to Linus, and in mainline. :-)
- Ted
next prev parent reply other threads:[~2008-10-14 2:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 8:47 [PATCH 0/4] ext4/jbd2: possible filesystem corruption fixes Hidehiro Kawai
2008-10-10 8:57 ` [PATCH 1/4] jbd2: abort when failed to log metadata buffers Hidehiro Kawai
2008-10-10 8:58 ` [PATCH 2/4] jbd2: fix error handling for checkpoint io Hidehiro Kawai
2008-10-10 9:00 ` [PATCH 3/4] ext4: add checks for errors from jbd2 Hidehiro Kawai
2008-10-10 9:02 ` [PATCH 4/4] jbd2: don't dirty original metadata buffer on abort Hidehiro Kawai
2008-10-13 20:36 ` Joel Becker
2008-10-14 2:58 ` Theodore Tso [this message]
2008-10-11 4:25 ` [PATCH 0/4] ext4/jbd2: possible filesystem corruption fixes Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014025814.GB9332@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).