From: Andrew Morton <akpm@linux-foundation.org>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH,RFC] ext3: Add support for non-native signed/unsigned htree hash algorithms
Date: Wed, 22 Oct 2008 17:22:21 -0700 [thread overview]
Message-ID: <20081022172221.c1a8c5b5.akpm@linux-foundation.org> (raw)
In-Reply-To: <1224560624-9691-2-git-send-email-tytso@mit.edu>
On Mon, 20 Oct 2008 23:43:44 -0400
"Theodore Ts'o" <tytso@mit.edu> wrote:
> + i = le32_to_cpu(es->s_flags);
> + if (i & EXT2_FLAGS_UNSIGNED_HASH)
> + sbi->s_hash_unsigned = 3;
> + else if ((i & EXT2_FLAGS_SIGNED_HASH) == 0) {
> + char c;
> +
> + c = (char) 255;
> + if (((int) c) == -1) {
arm says
fs/ext3/super.c: In function `ext3_fill_super':
fs/ext3/super.c:1750: warning: comparison is always false due to limited range of data type
Also, is there any way in which this new code can be, umm, cleaned up?
next prev parent reply other threads:[~2008-10-23 0:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 3:43 [PATCH,RFC] ext4: Add support for non-native signed/unsigned htree hash algorithms Theodore Ts'o
2008-10-21 3:43 ` [PATCH,RFC] ext3: " Theodore Ts'o
2008-10-21 7:16 ` Daniel Phillips
2008-10-21 21:50 ` Daniel Phillips
2008-10-21 21:53 ` Daniel Phillips
2008-10-22 16:30 ` Matt Mackall
2008-10-23 0:22 ` Andrew Morton [this message]
2008-10-23 2:56 ` Theodore Tso
2008-10-23 19:26 ` Andreas Dilger
2008-10-24 18:25 ` Jeremy Fitzhardinge
2008-10-28 14:24 ` Theodore Tso
2008-10-28 17:30 ` tony.luck
2008-11-03 7:33 ` Olaf Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022172221.c1a8c5b5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox