From: Christoph Hellwig <hch@infradead.org>
To: Andreas Dilger <adilger@sun.com>
Cc: Akira Fujita <a-fujita@rs.jp.nec.com>,
linux-ext4@vger.kernel.org, Theodore Tso <tytso@mit.edu>,
Mingming Cao <cmm@us.ibm.com>
Subject: Re: [RFC][PATCH 7/9]ext4: Add the EXT4_IOC_FIEMAP_INO ioctl
Date: Sun, 26 Oct 2008 04:48:48 -0400 [thread overview]
Message-ID: <20081026084848.GA9270@infradead.org> (raw)
In-Reply-To: <20081026084048.GF3184@webber.adilger.int>
On Sun, Oct 26, 2008 at 02:40:48AM -0600, Andreas Dilger wrote:
> This was mentioned last time these patches were posted, but there was
> no reply from you. Christoph suggested a more generic VFS open-by-inum,
> which isn't impossible to do but would cause a lot of controversy I
> think, while the EXT4_IOC_WRAPPER is at least contained within ext4,
> but is more generically useful than EXT4_IOC_FIEMAP_INO.
I'll hack up a generic open_by_handle and then we can gather the
reaction - it shouldn't be more than about one or two hundred lines of
code. Note that you really want an open by handle and not just inum for
a defragmentation tool - without the generation you can easily run into
races.
Btw, any reason the XFS approach of passing in filehandles for both
the inode to be defragmented and the "donor" inode doesn't work for you?
next prev parent reply other threads:[~2008-10-26 8:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 10:09 [RFC][PATCH 7/9]ext4: Add the EXT4_IOC_FIEMAP_INO ioctl Akira Fujita
2008-10-26 8:40 ` Andreas Dilger
2008-10-26 8:48 ` Christoph Hellwig [this message]
2008-10-26 8:49 ` Christoph Hellwig
2008-10-31 10:05 ` Christoph Hellwig
2008-11-06 7:39 ` Akira Fujita
2008-11-06 16:15 ` Theodore Tso
2008-10-27 10:21 ` Akira Fujita
2008-10-27 19:55 ` Andreas Dilger
2008-10-31 9:46 ` Akira Fujita
2008-11-04 21:42 ` Andreas Dilger
-- strict thread matches above, loose matches on Subject: below --
2008-11-13 11:34 Akira Fujita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081026084848.GA9270@infradead.org \
--to=hch@infradead.org \
--cc=a-fujita@rs.jp.nec.com \
--cc=adilger@sun.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).