From: Valerie Aurora Henson <vaurora@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: Theodore Tso <tytso@mit.edu>, "Jose R. Santos" <jrs@us.ibm.com>
Subject: 64-bit dblists
Date: Mon, 27 Oct 2008 16:59:10 -0400 [thread overview]
Message-ID: <20081027205910.GD20992@shell> (raw)
Hi all,
In my continuing quest to finish the 64-bit conversion of e2fsprogs, I
ran into this structure exported in ext2fs.h:
struct ext2_db_entry {
ext2_ino_t ino;
blk_t blk;
int blockcnt;
};
The "blk_t" is the problem here - we need a blk64_t. A pointer to
this structure is passed to the user-provided directory block iterator
in ext2fs_dblist_iterate().
Assuming the goal is to preserve the ext2fs_dblist ABI, I can see two
ways of doing this:
1. Define ext2_db_entry2, ext2_dblist2, and ext2fs_dblist_*2() and do
the usual translation/conversion function business.
2. Use the magic number in the dblist to differentiate between old and
new-style dblists and keep the existing interfaces for functions that
only pass around pointers. We'll also need ext2fs_dblist_iterate2()
and ext2fs_get_last2().
I find option #1 slightly less unpalatable than #2. Does anyone have
an option #3?
-VAL
next reply other threads:[~2008-10-27 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 20:59 Valerie Aurora Henson [this message]
2008-11-03 3:09 ` 64-bit dblists Theodore Tso
2008-11-12 16:48 ` Valerie Aurora Henson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027205910.GD20992@shell \
--to=vaurora@redhat.com \
--cc=jrs@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).