From: Theodore Tso <tytso@mit.edu>
To: Sami Liedes <sliedes@cc.hut.fi>
Cc: sct@redhat.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] jbd2: deregister proc on failure in jbd2_journal_init_inode
Date: Sun, 2 Nov 2008 18:48:50 -0500 [thread overview]
Message-ID: <20081102234850.GP8134@mit.edu> (raw)
In-Reply-To: <20081102195857.GM5994@lh.kyla.fi>
On Sun, Nov 02, 2008 at 09:58:57PM +0200, Sami Liedes wrote:
> jbd2_journal_init_inode() does not call jbd2_stats_proc_exit() on all
> failure paths after calling jbd2_stats_proc_init(). This leaves
> dangling references to the fs in proc.
>
> This patch fixes bug #11493.
>
> Signed-off-by: Sami Liedes <sliedes@cc.hut.fi>
>
> ---
>
> I hope this is correct. I don't understand the code very well, but I
> did test my patch and it seems to fix the problem. Please don't hit me
> too hard, this is the first kernel patch I have ever submitted.
The patch looks good. I'll get this into the ext4 patch queue and
queue it for submission to Linus. I normally reference kernel bugs
via the full URL, i.e:
This patch fixes a bug reported by Sami Leides at:
http://bugzilla.kernel.org/show_bug.cgi?id=11493
...but that's just a tiny nit. Thanks!!
- Ted
prev parent reply other threads:[~2008-11-02 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 19:58 [PATCH] jbd2: deregister proc on failure in jbd2_journal_init_inode Sami Liedes
2008-11-02 23:48 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081102234850.GP8134@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sct@redhat.com \
--cc=sliedes@cc.hut.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).