From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, sandeen@redhat.com, vallesroc@gmail.com,
Solofo.Ramangalahy@bull.net, cryptooctoploid@gmail.com,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH -V2] ext4: Mark the buffer_heads as dirty and uptodate after prepare_write
Date: Fri, 7 Nov 2008 08:33:03 -0500 [thread overview]
Message-ID: <20081107133303.GA9543@mit.edu> (raw)
In-Reply-To: <1226063563-16220-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Per discussion on IRC, we've Aneesh and I have concluded that the V1
patch is correct, and in fact calling block_commit_write() when we
will be redirtying the page (a) can cause problems if one or more
buffer heads on the page is marked for delayed allocation and so
bh->block_nr is 0, and (b) wastes disk bandwidth since the page
contents will be potentially written out twice.
So we'll be going with the V1 version of the patch, and pushing it to
Linus ASAP.
- Ted
prev parent reply other threads:[~2008-11-07 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 13:12 [PATCH -V2] ext4: Mark the buffer_heads as dirty and uptodate after prepare_write Aneesh Kumar K.V
2008-11-07 13:33 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107133303.GA9543@mit.edu \
--to=tytso@mit.edu \
--cc=Solofo.Ramangalahy@bull.net \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=cryptooctoploid@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=vallesroc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).