Re: [PATCH] filesystems: use has_capability_noaudit interface for reserved blocks checks

Artem Bityutskiy
2008-11-14T08:00:22Z

Eric Paris wrote:
> ext[2,3,4], ufs, and ubifs all check for CAP_SYS_RESOURCE to determine
> if they should allow reserved blocks to be used. A process not having
> this capability is not failing some security decision and should not be
> audited. Thus move to using has_capability_noaudit.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
> ---

UBIFS part looks OK, as long as the whole idea of the patch is right, which
I have not checked, but assume it is.

The only question is are you sure exporting 'cap_capable()' is relevant
to this patch? You do not seem to call it directly.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html