From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: cmm@us.ibm.com, tytso@mit.edu, sandeen@redhat.com,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH -V4] ext4: sparse fixes
Date: Fri, 21 Nov 2008 23:25:34 +0530 [thread overview]
Message-ID: <20081121175534.GI11212@skywalker> (raw)
In-Reply-To: <20081121175110.GA12412@infradead.org>
On Fri, Nov 21, 2008 at 12:51:10PM -0500, Christoph Hellwig wrote:
> On Fri, Nov 21, 2008 at 10:10:36PM +0530, Aneesh Kumar K.V wrote:
> > #define EXT4_HAS_COMPAT_FEATURE(sb,mask) \
> > - (EXT4_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask))
> > + (__force __u32)!!(EXT4_SB(sb)->s_es->s_feature_compat & \
> > + cpu_to_le32(mask))
>
> As mentioned before please don't abuse __force here.
>
> ((EXT4_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask)) != 0)
>
> does the right things and is a lote more readable.
I thought your comment was on returning value that had multiple flag bit
set. I didn't look at the __force usage as bad. I will send an updated patch.
-aneesh
prev parent reply other threads:[~2008-11-21 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 16:40 [PATCH -V4] ext4: sparse fixes Aneesh Kumar K.V
2008-11-21 17:51 ` Christoph Hellwig
2008-11-21 17:55 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121175534.GI11212@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).