From: curtw@google.com (Curt Wohlgemuth)
To: linux-ext4@vger.kernel.org
Subject: PATCH ext4: fix to call_filldir
Date: Mon, 24 Nov 2008 10:21:05 -0800 (PST) [thread overview]
Message-ID: <20081124182105.184338C977@localhost> (raw)
[ Sorry: I mistakenly sent just the patch, with no explanation... ]
I happened to find a bug running bonnie++-1.03a on an ext4 filesystem, when
it complained about not being able to remove a file.
Further investigation showed a problem with call_filldir(), which is not
quite correct with respect to the same function in fs/ext3/dir.c. The patch
below fixes this problem.
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
---
diff -Naur ext4/fs/ext4/dir.c b/fs/ext4/dir.c
--- ext4/fs/ext4/dir.c 2008-11-13 14:51:58.000000000 -0800
+++ b/fs/ext4/dir.c 2008-11-24 08:23:05.000000000 -0800
@@ -417,7 +417,7 @@
get_dtype(sb, fname->file_type));
if (error) {
filp->f_pos = curr_pos;
- info->extra_fname = fname;
+ info->extra_fname = fname->next;
return error;
}
fname = fname->next;
next reply other threads:[~2008-11-24 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 18:21 Curt Wohlgemuth [this message]
2008-11-24 21:51 ` PATCH ext4: fix to call_filldir Theodore Tso
2008-11-24 22:59 ` Curt Wohlgemuth
2008-11-25 2:05 ` Theodore Tso
-- strict thread matches above, loose matches on Subject: below --
2008-11-24 18:18 Curt Wohlgemuth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124182105.184338C977@localhost \
--to=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).