From: Andreas Dilger <adilger@sun.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Josef Bacik <jbacik@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] imporve jbd2 fsync batching
Date: Tue, 25 Nov 2008 15:41:15 -0700 [thread overview]
Message-ID: <20081125224115.GW3186@webber.adilger.int> (raw)
In-Reply-To: <20081125102335.GB9882@mit.edu>
On Nov 25, 2008 05:23 -0500, Theodore Ts'o wrote:
> On Tue, Nov 04, 2008 at 11:10:25AM -0500, Josef Bacik wrote:
> > + commit_time = ktime_to_ns(ktime_sub(ktime_get(), start_time));
> > +
> > + /*
> > + * weight the commit time higher than the average time so we don't
> > + * react too strongly to vast changes in the commit time
> > + */
> > + if (likely(journal->j_average_commit_time))
> > + journal->j_average_commit_time = (commit_time*3 +
> > + journal->j_average_commit_time) / 4;
>
> Stupid question... if the goal is to not have the average commit time
> not react too strongly to sudden and vast changes to the commit time,
> would it be better to do this instead:
>
> > + journal->j_average_commit_time = (commit_time +
> > + journal->j_average_commit_time*3) / 4;
Actually, yes. That is my fault, I'd suggested the original change to
Josef.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
next prev parent reply other threads:[~2008-11-25 22:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 16:10 [PATCH] imporve jbd2 fsync batching Josef Bacik
2008-11-04 20:52 ` Theodore Tso
2008-11-04 22:15 ` Leroy van Logchem
2008-11-05 23:10 ` Andreas Dilger
2008-11-06 0:27 ` Theodore Tso
2008-11-06 12:45 ` Ric Wheeler
2008-11-25 10:22 ` [PATCH] ext4: add fsync batch tuning knobs Theodore Tso
2008-12-02 14:45 ` Aneesh Kumar K.V
2008-11-06 14:35 ` [PATCH] imporve jbd2 fsync batching Josef Bacik
2008-11-25 10:23 ` Theodore Tso
2008-11-25 22:41 ` Andreas Dilger [this message]
2008-11-26 5:10 ` Theodore Tso
2008-11-26 13:18 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125224115.GW3186@webber.adilger.int \
--to=adilger@sun.com \
--cc=jbacik@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).