linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, sandeen@redhat.com, vallesroc@gmail.com,
	Solofo.Ramangalahy@bull.net, cryptooctoploid@gmail.com,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Fix the delalloc writepages to allocate blocks at the right offset.
Date: Wed, 26 Nov 2008 00:53:21 -0500	[thread overview]
Message-ID: <20081126055321.GF1410@mit.edu> (raw)
In-Reply-To: <1226050948-32221-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

On Fri, Nov 07, 2008 at 03:12:27PM +0530, Aneesh Kumar K.V wrote:
> When iterating through the pages with all mapped buffer_heads
> we failed to update the b_state value. This result in allocating
> blocks at logical offset 0.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

Hey Aneesh,

I've been going through patches in the patch queue and I noticed that
the subsequent patch 

[PATCH 2/2] ext4: Mark the buffer_heads as dirty and uptodate after prepare_write

has been merged to mainline, but this one wasn't.  From looking at the
e-mail record, you said that the second one fixed the rtorrent
corruption --- but looking at this patch and its description, it looks
like this one should perhaps get pushed to Linus ASAP as well.  Do you
remember if both patches were needed to fix the rtorrent corruption
problem, or only the second one?

Thanks,

						- Ted

  parent reply	other threads:[~2008-11-26  5:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07  9:42 [PATCH 1/2] ext4: Fix the delalloc writepages to allocate blocks at the right offset Aneesh Kumar K.V
2008-11-07  9:42 ` [PATCH 2/2] ext4: Mark the buffer_heads as dirty and uptodate after prepare_write Aneesh Kumar K.V
2008-11-07  9:45   ` Aneesh Kumar K.V
2008-11-26  5:53 ` Theodore Tso [this message]
2008-11-27  5:37   ` [PATCH 1/2] ext4: Fix the delalloc writepages to allocate blocks at the right offset Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126055321.GF1410@mit.edu \
    --to=tytso@mit.edu \
    --cc=Solofo.Ramangalahy@bull.net \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=cryptooctoploid@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=vallesroc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).