Re: [PATCH 2/2] Large EAs

[Theodore Tso <tytso@mit.edu>]

On Wed, Nov 26, 2008 at 11:30:32AM +0530, Kalpak Shah wrote:
> On Wed, Nov 26, 2008 at 10:11 AM, Theodore Tso <tytso@mit.edu> wrote:
> > Sorry for not reviewing this patch earlier, but looking at the disk
> > format, I wonder if it's really necessary to allocate an inode for
> > each EA.  Given that we have a fixed inode table, if the user creates
> > a large number of 2k EA's (on a 4k filesystem) or 512 byte EA's (on a
> > 1k) filesystem, this could easily burn a huge number of inodes,
> > causing users to run out.
> >
> > We don't actually *need* to use an inode;
> 
> One of the reasons we need to use an inode is that orphan EA inodes
> can be linked into lost+found. If we just use an extent tree, I am not
> sure how e2fsck can find out orphan EAs.

It's already the case that if we have an orphaned EA block, we'll lose
it.  The question is whether it's important to keep a large EA if it
gets orphaned, especially given that there are already plenty ways
that we can lose EA's (i.e., ftp, tar, NFSv3, etc.).  So if someone is
going to store a multi-megabyte EA, and we lose it because the inode
it was attached to gets destroyed, or the inode gets corrupted to the
point where we can't find the root of the EA tree --- the question is
--- will we care?  It's similar to losing the high-level node in the
EA tree, we lose all the leaf nodes below it.  It can happen, but in
that case the user will just have to restore the entire file from
backup. I'd argue that losing the EA tree would be the same sort of
thing.

I can see the argument on the other side, where if someone attaches a
multi-megabyte EA to a file, that it might be important enough to be
worth saving.  OTOH I'm not at all sure we would want to encourage
such a thing!

							- Ted