public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, sandeen@redhat.com, Alex.Zhuravlev@Sun.COM,
	linux-ext4@vger.kernel.org, Mark Fasheh <mfasheh@suse.com>
Subject: Re: [PATCH -V1] ext4: Use new buffer_head flag to check uninit group bitmaps initialization
Date: Wed, 26 Nov 2008 10:56:43 -0500	[thread overview]
Message-ID: <20081126155643.GA8741@mit.edu> (raw)
In-Reply-To: <1227711250-13934-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

On Wed, Nov 26, 2008 at 08:24:10PM +0530, Aneesh Kumar K.V wrote:
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 4932b34..6694561 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -329,6 +329,7 @@ enum jbd_state_bits {
>  	BH_State,		/* Pins most journal_head state */
>  	BH_JournalHead,		/* Pins bh->b_private and jh->b_bh */
>  	BH_Unshadow,		/* Dummy bit, for BJ_Shadow wakeup filtering */
> +	BH_JBD_State_bits_End,
>  };
>  
>  BUFFER_FNS(JBD, jbd)

Note: this conflicts with a patch by Mark Fasheh which does something
very similar, since OCFS2 also needs some private BH flags.  He used
the name BH_JBDPrivateStart, though.

Originally the plan was going to be that Mark was going to send this
to Linus, but given that we need it as well, I suggest that we drop it
into both the OCFS2 and ext4 trees, and whichever one hits Linus's
tree first will win, and in the other case the magic of git's merge
algorithms should make the right thing happen in the second.  (Or the
other team can drop the patch before they merge; either will do the
right thing.)

For this path, it would mean dropping this hunk and adding Mark's
patch to the ext4 tree.  If this makes sense to everyone, Aneesh, you
don't need to send a patch; I can fix up the one you sent easily
enough.

						- Ted

  reply	other threads:[~2008-11-26 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26 14:54 [PATCH -V1] ext4: Use new buffer_head flag to check uninit group bitmaps initialization Aneesh Kumar K.V
2008-11-26 15:56 ` Theodore Tso [this message]
2008-11-26 16:20   ` Aneesh Kumar K.V
2008-11-26 16:22   ` Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126155643.GA8741@mit.edu \
    --to=tytso@mit.edu \
    --cc=Alex.Zhuravlev@Sun.COM \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox