From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Akira Fujita <a-fujita@rs.jp.nec.com>
Cc: Theodore Tso <tytso@mit.edu>, Li Zefan <lizf@cn.fujitsu.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH]ext4: fix s_dirty_blocks_counter if block allocation failed with nodelalloc
Date: Mon, 1 Dec 2008 16:06:41 +0530 [thread overview]
Message-ID: <20081201103641.GA13242@skywalker> (raw)
In-Reply-To: <4933BAC2.6080004@rs.jp.nec.com>
On Mon, Dec 01, 2008 at 07:21:54PM +0900, Akira Fujita wrote:
> ext4: Fix s_dirty_blocks_counter if block allocation failed with nodelalloc
>
> From: Akira Fujita <a-fujita@rs.jp.nec.com>
>
> If block allocation failed after marking claimed blocks as dirty blocks
> with nodelalloc, we have to subtract these blocks from
> s_dirty_blocks_counter in error handling.
> Otherwise s_dirty_blocks_counter goes wrong so that
> filesystem's free blocks decreases incorrectly.
Why did the block allocation fail ? With delayed allocation ENOSPC
should not happen during block allocation. That would mean we did
something wrong in block reservation.
>
> This issue was reported as ext4 online defrag's bug by Li Zefan.
> http://marc.info/?l=linux-ext4&m=122697235715170&w=2
-aneesh
next prev parent reply other threads:[~2008-12-01 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 10:21 [PATCH]ext4: fix s_dirty_blocks_counter if block allocation failed with nodelalloc Akira Fujita
2008-12-01 10:36 ` Aneesh Kumar K.V [this message]
2008-12-04 1:27 ` Akira Fujita
2008-12-04 5:07 ` Aneesh Kumar K.V
2008-12-04 8:32 ` Akira Fujita
2008-12-04 8:38 ` Li Zefan
-- strict thread matches above, loose matches on Subject: below --
2008-12-04 14:04 [PATCH] ext4: Fix " Aneesh Kumar K.V
2008-12-04 18:19 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081201103641.GA13242@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=linux-ext4@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).