linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <gregkh@suse.de>
To: lizf@cn.fujitsu.com, gregkh@suse.de, linux-ext4@vger.kernel.org,
	tytso@mit.edu
Cc: <stable@kernel.org>, <stable-commits@vger.kernel.org>
Subject: patch ext4-add-missing-unlock-in-ext4_check_descriptors-on-error-path.patch added to 2.6.27-stable tree
Date: Wed, 03 Dec 2008 10:55:49 -0800	[thread overview]
Message-ID: <20081203185913.E6B2A48D91@coco.kroah.org> (raw)
In-Reply-To: <1226851540-8032-5-git-send-email-tytso@mit.edu>


This is a note to let you know that we have just queued up the patch titled

    Subject: ext4: add missing unlock in ext4_check_descriptors() on error path

to the 2.6.27-stable tree.  Its filename is

    ext4-add-missing-unlock-in-ext4_check_descriptors-on-error-path.patch

A git repo of this tree can be found at 
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary


>From tytso@mit.edu  Wed Dec  3 09:57:50 2008
From: Li Zefan <lizf@cn.fujitsu.com>
Date: Sun, 16 Nov 2008 11:05:24 -0500
Subject: ext4: add missing unlock in ext4_check_descriptors() on error path
To: stable@kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>, Ext4 Developers List <linux-ext4@vger.kernel.org>, Li Zefan <lizf@cn.fujitsu.com>
Message-ID: <1226851540-8032-5-git-send-email-tytso@mit.edu>


From: Li Zefan <lizf@cn.fujitsu.com>

(cherry picked from commit 7ee1ec4ca30c6df8e989615cdaacb75f2af4fa6b)

If there group descriptors are corrupted we need unlock the block
group lock before returning from the function; else we will oops when
freeing a spinlock which is still being held.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 fs/ext4/super.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1626,8 +1626,10 @@ static int ext4_check_descriptors(struct
 			       "Checksum for group %lu failed (%u!=%u)\n",
 			       i, le16_to_cpu(ext4_group_desc_csum(sbi, i,
 			       gdp)), le16_to_cpu(gdp->bg_checksum));
-			if (!(sb->s_flags & MS_RDONLY))
+			if (!(sb->s_flags & MS_RDONLY)) {
+				spin_unlock(sb_bgl_lock(sbi, i));
 				return 0;
+			}
 		}
 		spin_unlock(sb_bgl_lock(sbi, i));
 		if (!flexbg_flag)


Patches currently in stable-queue which might be from lizf@cn.fujitsu.com are

queue-2.6.27/cpuset-fix-regression-when-failed-to-generate-sched-domains.patch
queue-2.6.27/cgroups-fix-a-serious-bug-in-cgroupstats.patch
queue-2.6.27/ext4-add-missing-unlock-in-ext4_check_descriptors-on-error-path.patch

  parent reply	other threads:[~2008-12-03 18:59 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-16 16:05 [FOR-STABLE 0/20] Theodore Ts'o
2008-11-16 16:05 ` [FOR-STABLE 01/20] Update flex_bg free blocks and free inodes counters when resizing Theodore Ts'o
2008-11-16 16:05   ` [FOR-STABLE 02/20] ext4: fix #11321: create /proc/ext4/*/stats more carefully Theodore Ts'o
2008-11-16 16:05     ` [FOR-STABLE 03/20] jbd2: fix /proc setup for devices that contain '/' in their names Theodore Ts'o
2008-11-16 16:05       ` [FOR-STABLE 04/20] ext4: add missing unlock in ext4_check_descriptors() on error path Theodore Ts'o
2008-11-16 16:05         ` [FOR-STABLE 05/20] ext4: elevate write count for migrate ioctl Theodore Ts'o
2008-11-16 16:05           ` [FOR-STABLE 06/20] ext4: Renumber EXT4_IOC_MIGRATE Theodore Ts'o
2008-11-16 16:05             ` [FOR-STABLE 07/20] ext4/jbd2: Avoid WARN() messages when failing to write to the superblock Theodore Ts'o
2008-11-16 16:05               ` [FOR-STABLE 08/20] ext4: fix initialization of UNINIT bitmap blocks Theodore Ts'o
2008-11-16 16:05                 ` [FOR-STABLE 09/20] jbd2: abort instead of waiting for nonexistent transaction Theodore Ts'o
2008-11-16 16:05                   ` [FOR-STABLE 10/20] jbd2: Fix buffer head leak when writing the commit block Theodore Ts'o
2008-11-16 16:05                     ` [FOR-STABLE 11/20] ext4: fix xattr deadlock Theodore Ts'o
2008-11-16 16:05                       ` [FOR-STABLE 12/20] ext4: Free ext4_prealloc_space using kmem_cache_free Theodore Ts'o
2008-11-16 16:05                         ` [FOR-STABLE 13/20] ext4: Do mballoc init before doing filesystem recovery Theodore Ts'o
2008-11-16 16:05                           ` [FOR-STABLE 14/20] ext4: Fix duplicate entries returned from getdents() system call Theodore Ts'o
2008-11-16 16:05                             ` [FOR-STABLE 15/20] jbd2: don't give up looking for space so easily in __jbd2_log_wait_for_space Theodore Ts'o
2008-11-16 16:05                               ` [FOR-STABLE 16/20] ext4: Convert to host order before using the values Theodore Ts'o
2008-11-16 16:05                                 ` [FOR-STABLE 17/20] ext4: wait on all pending commits in ext4_sync_fs() Theodore Ts'o
2008-11-16 16:05                                   ` [FOR-STABLE 18/20] ext4: calculate journal credits correctly Theodore Ts'o
2008-11-16 16:05                                     ` [FOR-STABLE 19/20] ext4: Mark the buffer_heads as dirty and uptodate after prepare_write Theodore Ts'o
2008-11-16 16:05                                       ` [FOR-STABLE 20/20] ext4: add checksum calculation when clearing UNINIT flag in ext4_new_inode Theodore Ts'o
2008-12-03 18:55                                         ` patch ext4-add-checksum-calculation-when-clearing-uninit-flag-in-ext4_new_inode.patch added to 2.6.27-stable tree gregkh
2008-12-03 18:56                                       ` patch ext4-mark-the-buffer_heads-as-dirty-and-uptodate-after-prepare_write.patch " gregkh
2008-12-03 18:55                                     ` patch ext4-calculate-journal-credits-correctly.patch " gregkh
2008-12-03 18:56                                   ` patch ext4-wait-on-all-pending-commits-in-ext4_sync_fs.patch " gregkh
2008-12-03 18:55                                 ` patch ext4-convert-to-host-order-before-using-the-values.patch " gregkh
2008-12-03 18:56                               ` patch jbd2-don-t-give-up-looking-for-space-so-easily-in-__jbd2_log_wait_for_space.patch " gregkh
2008-12-03 18:55                             ` patch ext4-fix-duplicate-entries-returned-from-getdents-system-call.patch " gregkh
2008-12-03 18:55                           ` patch ext4-do-mballoc-init-before-doing-filesystem-recovery.patch " gregkh
2008-12-03 18:55                         ` patch ext4-free-ext4_prealloc_space-using-kmem_cache_free.patch " gregkh
2008-12-03 18:55                       ` patch ext4-fix-xattr-deadlock.patch " gregkh
2008-12-03 18:56                     ` patch jbd2-fix-buffer-head-leak-when-writing-the-commit-block.patch " gregkh
2008-12-03 18:56                   ` patch jbd2-abort-instead-of-waiting-for-nonexistent-transaction.patch " gregkh
2008-12-03 18:55                 ` patch ext4-fix-initialization-of-uninit-bitmap-blocks.patch " gregkh
2008-12-03 18:56               ` patch ext4-jbd2-avoid-warn-messages-when-failing-to-write-to-the-superblock.patch " gregkh
2008-12-03 18:56             ` patch ext4-renumber-ext4_ioc_migrate.patch " gregkh
2008-12-03 18:55           ` patch ext4-elevate-write-count-for-migrate-ioctl.patch " gregkh
2008-12-03 18:55         ` gregkh [this message]
2008-12-03 18:56       ` patch jbd2-fix-proc-setup-for-devices-that-contain-in-their-names.patch " gregkh
2008-12-03 18:55     ` patch ext4-fix-11321-create-proc-ext4-stats-more-carefully.patch " gregkh
2008-12-03 18:56   ` patch ext4-update-flex_bg-free-blocks-and-free-inodes-counters-when-resizing.patch " gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081203185913.E6B2A48D91@coco.kroah.org \
    --to=gregkh@suse.de \
    --cc=linux-ext4@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).