From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, sandeen@redhat.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Don't overwrite allocation_context ac_status
Date: Fri, 12 Dec 2008 12:59:22 -0500 [thread overview]
Message-ID: <20081212175922.GC26085@mit.edu> (raw)
In-Reply-To: <1228914463-12716-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Wed, Dec 10, 2008 at 06:37:43PM +0530, Aneesh Kumar K.V wrote:
> We can call ext4_mb_check_limits even after successfull
> allocation. Make sure we don't overwrite ac_status.
> This fix the below lockdep warning
So the ext4_mb_check_limits() function isn't that well documented, but
one of the things it is supposed to do is to make sure that blocks
comprising the extent that was found is in fact still available. This
check patches this out. Are we sure this does the right thing?
- Ted
next prev parent reply other threads:[~2008-12-12 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 13:07 [PATCH] ext4: Don't overwrite allocation_context ac_status Aneesh Kumar K.V
2008-12-12 17:59 ` Theodore Tso [this message]
2008-12-17 8:54 ` Aneesh Kumar K.V
2009-01-02 5:23 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081212175922.GC26085@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).