From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, Theodore Tso <tytso@mit.edu>,
adilger@sun.com, linux-ext4@vger.kernel.org
Subject: [PATCH] ext4: annotate unhandled kmem_cache_alloc() error
Date: Tue, 23 Dec 2008 19:40:18 +0900 [thread overview]
Message-ID: <20081223104016.GC7217@localhost.localdomain> (raw)
kmem_cache_alloc() error in ext4_mb_free_metadata is not handled.
I don't know how to fix it. But I can put BUG_ON to let others
know the problem.
Cc: Theodore Tso <tytso@mit.edu>
Cc: adilger@sun.com
Cc: linux-ext4@vger.kernel.org
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
fs/ext4/mballoc.c | 1 +
1 file changed, 1 insertion(+)
Index: 2.6-rc/fs/ext4/mballoc.c
===================================================================
--- 2.6-rc.orig/fs/ext4/mballoc.c
+++ 2.6-rc/fs/ext4/mballoc.c
@@ -4417,6 +4417,7 @@ ext4_mb_free_metadata(handle_t *handle,
BUG_ON(e4b->bd_buddy_page == NULL);
new_entry = kmem_cache_alloc(ext4_free_ext_cachep, GFP_NOFS);
+ BUG_ON(!new_entry);
new_entry->start_blk = block;
new_entry->group = group;
new_entry->count = count;
next reply other threads:[~2008-12-23 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 10:40 Akinobu Mita [this message]
2008-12-23 14:29 ` [PATCH] ext4: annotate unhandled kmem_cache_alloc() error Josef Bacik
2008-12-23 22:37 ` Akinobu Mita
2009-01-11 2:03 ` [PATCH] ext4: fix unhandled ext4_free_data allocation failure Akinobu Mita
2009-01-11 14:39 ` Josef Bacik
2009-01-11 14:46 ` Eric Sandeen
2009-01-12 3:58 ` Theodore Tso
2009-01-12 15:03 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081223104016.GC7217@localhost.localdomain \
--to=akinobu.mita@gmail.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).