From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Theodore Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: The meaning of data=ordered as it relates to delayed allocation
Date: Mon, 19 Jan 2009 20:15:54 +0530 [thread overview]
Message-ID: <20090119144554.GJ9482@skywalker> (raw)
In-Reply-To: <20090119124513.GC7598@mit.edu>
On Mon, Jan 19, 2009 at 07:45:13AM -0500, Theodore Tso wrote:
> On Mon, Jan 19, 2009 at 10:13:45AM +0530, Aneesh Kumar K.V wrote:
> > > So I wonder if we should either:
> > >
> > > (a) make data=ordered force block allocation and writeback --- which
> > > should just be a matter of disabling the
> > > redirty_page_for_writepage() code path in ext4_da_writepage()
> >
> > We can't do that because we cannot do block allocation there. So we need
> > to redirty the page that have unmapped buffer_heads.
>
> What is preventing us from doing block allocation from
> ext4_da_writepage()?
>
The callback is called with page lock held and we can't start a journal
with page lock held.
-aneesh
next prev parent reply other threads:[~2009-01-19 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 0:52 The meaning of data=ordered as it relates to delayed allocation Theodore Ts'o
2009-01-19 4:43 ` Aneesh Kumar K.V
2009-01-19 12:45 ` Theodore Tso
2009-01-19 14:45 ` Aneesh Kumar K.V [this message]
2009-01-26 13:24 ` Jan Kara
2009-01-19 19:10 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119144554.GJ9482@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).