From: Theodore Tso <tytso@mit.edu>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix oops when online resizing a filesystem with flex_bg
Date: Mon, 26 Jan 2009 19:22:48 -0500 [thread overview]
Message-ID: <20090127002248.GA11843@mit.edu> (raw)
In-Reply-To: <1232743309-3929-1-git-send-email-cascardo@holoscopio.com>
I'm going to include this patch as well, but with a slightly different
changelog description, since I think making sure the group descriptor
is initialized addresses the root cause of the problem. This still
saves a small amount of code space, so it's still a good patch, but it
shouldn't be strictly speaking necessary.
- Ted
commit 030d677ef688dea36245bdeaab74826aece02ee8
Author: Theodore Ts'o <tytso@mit.edu>
Date: Mon Jan 26 19:20:18 2009 -0500
ext4: remove call to ext4_group_desc() in ext4_group_used_meta_blocks()
The static function ext4_group_used_meta_blocks() only has one caller,
who already has access to the block group's group descriptor. So it's
better to have ext4_init_block_bitmap() pass the group descriptor to
ext4_group_used_meta_blocks(), so it doesn't need to call
ext4_group_desc(). Previously this function did not check if
ext4_group_desc() returned NULL due to an error, potentially causing a
kernel OOPS report. This avoids the issue entirely.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
prev parent reply other threads:[~2009-01-27 2:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 20:41 [PATCH] ext4: fix oops when online resizing a filesystem with flex_bg Thadeu Lima de Souza Cascardo
2009-01-27 0:07 ` Theodore Tso
2009-01-27 15:25 ` Thadeu Lima de Souza Cascardo
2009-01-27 0:22 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127002248.GA11843@mit.edu \
--to=tytso@mit.edu \
--cc=cascardo@holoscopio.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).