From: Theodore Tso <tytso@mit.edu>
To: Greg Freemyer <greg.freemyer@gmail.com>
Cc: Ric Wheeler <rwheeler@redhat.com>,
Thiemo Nagel <thiemo.nagel@ph.tum.de>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [RFC] ext4_bmap() may return blocks outside filesystem
Date: Thu, 5 Feb 2009 17:18:09 -0500 [thread overview]
Message-ID: <20090205221809.GD9814@mit.edu> (raw)
In-Reply-To: <87f94c370902051401s6d73d810s720f187c134f0b1e@mail.gmail.com>
On Thu, Feb 05, 2009 at 05:01:01PM -0500, Greg Freemyer wrote:
> > It also has absolutely nothing to do with the original thread, which
> > was block numbers which are far outside the range of valid block
> > numbers given the size of the block device. :-)
>
> The subject was "return blocks outside filesystem".
Yes, it's clear you didn't read the e-mail thread, but rather just
keyed off the subject line. :-)
> In a thin-provisioning environment I'd argue that unmapped sectors are
> "outside the filesystem". :)
>
> Unfortunately, I can't get anyone else to see the world from my
> apparently unique perspective. :(
If you don't like this, don't use thin-provisioned devices. Again, I
don't see the likely scenario where your fears are likely to be a
factor in a real world scenario. If there are bugs in the
thin-provisioned devices, people shouldn't use them. Given that we
are conservative about when we tell thin-provisioned devices that
blocks are no longer in use (i.e., on journal commits, and if we
crash, just don't tell the device the blocks can be reused), what's
the problem that you're worried about? How does it occur in real
life?
It's hard to defend against a theoretical problem when you only give
vague fears about how it might be triggered...
- Ted
next prev parent reply other threads:[~2009-02-05 22:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 12:03 [RFC] ext4_bmap() may return blocks outside filesystem Thiemo Nagel
2009-02-05 13:49 ` Theodore Tso
2009-02-05 15:22 ` Greg Freemyer
2009-02-05 15:39 ` Ric Wheeler
2009-02-05 16:48 ` Theodore Tso
2009-02-05 22:01 ` Greg Freemyer
2009-02-05 22:18 ` Theodore Tso [this message]
2009-02-07 13:27 ` Goswin von Brederlow
2009-02-07 15:51 ` Theodore Tso
2009-02-07 18:20 ` Ric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205221809.GD9814@mit.edu \
--to=tytso@mit.edu \
--cc=greg.freemyer@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=thiemo.nagel@ph.tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).