From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Thiemo Nagel <thiemo.nagel@ph.tum.de>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Validate extent details only when read from the disk
Date: Mon, 9 Feb 2009 16:18:57 +0530 [thread overview]
Message-ID: <20090209104857.GE31884@skywalker> (raw)
In-Reply-To: <49900612.3020609@ph.tum.de>
On Mon, Feb 09, 2009 at 11:31:46AM +0100, Thiemo Nagel wrote:
> Aneesh Kumar K.V wrote:
> > Make sure we validate extent details only when read from the disk.
> >
> > @@ -602,15 +607,13 @@ struct ext4_ext_path *
> > ext4_ext_find_extent(struct inode *inode, ext4_lblk_t block,
> > struct ext4_ext_path *path)
> > {
> > + int need_to_validate = 0;
> > struct ext4_extent_header *eh;
> > struct buffer_head *bh;
> > short int depth, i, ppos = 0, alloc = 0;
> >
> > eh = ext_inode_hdr(inode);
> > depth = ext_depth(inode);
> > - if (ext4_ext_check(inode, eh, depth))
> > - return ERR_PTR(-EIO);
> > -
>
I am doing the check in ext4_iget while reading the inode from disk.
-aneesh
next prev parent reply other threads:[~2009-02-09 10:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-07 15:36 [PATCH] introduce range check for extent pblock references Thiemo Nagel
2009-02-07 17:32 ` Aneesh Kumar K.V
2009-02-07 18:49 ` Thiemo Nagel
2009-02-07 19:59 ` Aneesh Kumar K.V
2009-02-07 20:01 ` [PATCH] Add checks to validate extent entries Aneesh Kumar K.V
2009-02-07 20:01 ` [PATCH] Validate extent details only when read from the disk Aneesh Kumar K.V
2009-02-09 10:31 ` Thiemo Nagel
2009-02-09 10:48 ` Aneesh Kumar K.V [this message]
2009-02-09 11:12 ` Thiemo Nagel
2009-02-09 10:26 ` [PATCH] Add checks to validate extent entries Thiemo Nagel
2009-02-09 10:31 ` Aneesh Kumar K.V
2009-02-09 10:40 ` Thiemo Nagel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209104857.GE31884@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=thiemo.nagel@ph.tum.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).