From: Theodore Tso <tytso@mit.edu>
To: Dan Carpenter <error27@gmail.com>
Cc: aneesh.kumar@linux.vnet.ibm.com, linux-ext4@vger.kernel.org,
adilger@sun.com
Subject: Re: [patch] Null dereference in ext4_ext_migrate()
Date: Sun, 15 Feb 2009 20:06:47 -0500 [thread overview]
Message-ID: <20090216010647.GA22619@mini-me.lan> (raw)
In-Reply-To: <alpine.DEB.2.00.0901302346430.12904@bikeee>
On Tue, Feb 03, 2009 at 10:49:22AM +0300, Dan Carpenter wrote:
> There is a potential null dereference of tmp_inode.
>
> The patch also removes an unnecessary check for whether tmp_inode is null.
>
> This was found through a code checker (http://repo.or.cz/w/smatch.git/).
> It looks like you might be able to trigger the error by trying to migrate
> a readonly file system. I have only compile tested though, sorry.
Thanks, I've included this in the ext4 patch queue to be pushed to Linus.
- Ted
prev parent reply other threads:[~2009-02-16 2:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 7:49 [patch] Null dereference in ext4_ext_migrate() Dan Carpenter
2009-02-16 1:06 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090216010647.GA22619@mini-me.lan \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=error27@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).