From: Theodore Tso <tytso@mit.edu>
To: Andreas Dilger <adilger@sun.com>
Cc: Wei Yongjun <yjwei@cn.fujitsu.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix to read empty directory blocks correctly in 64k blocksize filesystems
Date: Mon, 16 Feb 2009 19:05:09 -0500 [thread overview]
Message-ID: <20090217000509.GI23758@mini-me.lan> (raw)
In-Reply-To: <20090216233256.GI3199@webber.adilger.int>
On Mon, Feb 16, 2009 at 04:32:56PM -0700, Andreas Dilger wrote:
> There are probably a dozen other places in the ext* code that expect
> blocksize <= 65536, so I don't think this new encoding is really helping
> us at all. We are already restricted to 2^32-1 inodes due to the dirent
> format and I expect we will have changed the dirent format by that time
> anyways.
I can only find one other place, actually, which would be the extended
attribute code --- e_value_offs is a 16 bit offset (although we could
steal bits form e_value block if necessary).
> I'd rather keep this change as simple as possible (i.e. the original
> 65535 or 0 values, preferring 65535).
For 64k block sizes, I've kept this, although I preferred 0 since it's
a cleaner change if we want to allow bigger blocksize alternative. I
don't think 65535 is any worse than 0 in terms of detecting directory
corruption.
- Ted
prev parent reply other threads:[~2009-02-17 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 3:56 [PATCH] ext4: Fix to read empty directory blocks correctly in 64k blocksize filesystems Wei Yongjun
2009-02-10 8:26 ` [PATCHv2] ext4: Fix support for empty directory blocks " Wei Yongjun
2009-02-10 15:20 ` [PATCH] ext4: Fix to read empty directory blocks correctly " Theodore Tso
2009-02-11 5:48 ` Andreas Dilger
2009-02-11 15:15 ` Theodore Tso
2009-02-12 6:42 ` Wei Yongjun
2009-02-15 4:07 ` Theodore Tso
2009-02-16 23:32 ` Andreas Dilger
2009-02-17 0:05 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090217000509.GI23758@mini-me.lan \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).