From: Theodore Tso <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix deadlock in ext4_write_begin() and ext4_da_write_begin()
Date: Sun, 22 Feb 2009 21:16:35 -0500 [thread overview]
Message-ID: <20090223021635.GM17066@mit.edu> (raw)
In-Reply-To: <1235053488-16937-1-git-send-email-jack@suse.cz>
On Thu, Feb 19, 2009 at 03:24:48PM +0100, Jan Kara wrote:
> Functions ext4_write_begin() and ext4_da_write_begin() call
> grab_cache_page_write_begin() without AOP_FLAG_NOFS. Thus it
> can happen that page reclaim is triggered in that function
> and it recurses back into the filesystem (or some other filesystem).
> But this can lead to various problems as a transaction is already
> started at that point. Add the necessary flag.
>
> (Reported in http://bugzilla.kernel.org/show_bug.cgi?id=11688)
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Thanks, queued.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
- Ted
prev parent reply other threads:[~2009-02-23 2:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 14:24 [PATCH] ext4: Fix deadlock in ext4_write_begin() and ext4_da_write_begin() Jan Kara
2009-02-23 2:16 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090223021635.GM17066@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).