From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH, RFC] ext4: add EXT4_IOC_ALLOC_DA_BLKS ioctl
Date: Tue, 24 Feb 2009 15:08:32 +0530 [thread overview]
Message-ID: <20090224093832.GB25657@skywalker> (raw)
In-Reply-To: <1235451952-2726-5-git-send-email-tytso@mit.edu>
On Tue, Feb 24, 2009 at 12:05:50AM -0500, Theodore Ts'o wrote:
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 22dd29f..0d59f5f 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -262,6 +262,19 @@ setversion_out:
> return err;
> }
>
> + case EXT4_IOC_ALLOC_DA_BLKS:
> + {
> + int err;
> + if (!is_owner_or_cap(inode))
> + return -EACCES;
> +
> + err = mnt_want_write(filp->f_path.mnt);
> + if (err)
> + return err;
> + err = ext4_alloc_da_blocks(inode);
> + return err;
> + }
> +
I guess we need a matching
mnt_drop_write();
> default:
> return -ENOTTY;
> }
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-02-24 9:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 5:05 [PATCH, RFC] Clean up of delalloc code and map-on-close/rename fixes Theodore Ts'o
2009-02-24 5:05 ` [PATCH, RFC] ext4: Simplify delalloc implementation by removing mpd.get_block Theodore Ts'o
2009-02-24 5:05 ` [PATCH, RFC] ext4: Save stack space by removing fake buffer heads Theodore Ts'o
2009-02-24 5:05 ` [PATCH, RFC] ext4: Simplify delalloc code by removing mpage_da_writepages() Theodore Ts'o
2009-02-24 5:05 ` [PATCH, RFC] ext4: add EXT4_IOC_ALLOC_DA_BLKS ioctl Theodore Ts'o
2009-02-24 5:05 ` [PATCH, RFC] ext4: Automatically allocate delay allocated blocks on close Theodore Ts'o
2009-02-24 5:05 ` [PATCH, RFC] ext4: Automatically allocate delay allocated blocks on rename Theodore Ts'o
2009-02-24 10:13 ` [PATCH, RFC] ext4: Automatically allocate delay allocated blocks on close Andreas Dilger
2009-02-24 13:21 ` Theodore Tso
2009-02-24 9:38 ` Aneesh Kumar K.V [this message]
2009-02-24 13:14 ` [PATCH, RFC] ext4: add EXT4_IOC_ALLOC_DA_BLKS ioctl Theodore Tso
2009-02-24 10:11 ` Andreas Dilger
2009-02-24 13:16 ` Theodore Tso
2009-03-11 22:41 ` Eric Sandeen
2009-03-12 5:29 ` Aneesh Kumar K.V
2009-03-12 16:32 ` Eric Sandeen
2009-03-12 20:04 ` Theodore Tso
2009-03-12 20:05 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090224093832.GB25657@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).