From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] fix ext4_free_inode vs. ext4_claim_inode race
Date: Wed, 4 Mar 2009 19:06:03 -0500 [thread overview]
Message-ID: <20090305000603.GA30748@mit.edu> (raw)
In-Reply-To: <20090304190659.GB17949@skywalker>
On Thu, Mar 05, 2009 at 12:36:59AM +0530, Aneesh Kumar K.V wrote:
> On Tue, Mar 03, 2009 at 10:38:41PM -0600, Eric Sandeen wrote:
> > I was seeing fsck errors on inode bitmaps after a 4 thread
> > dbench run on a 4 cpu machine:
> >
> > Inode bitmap differences: -50736 -(50752--50753) etc...
> >
> > I believe that this is because ext4_free_inode() uses atomic
> > bitops, and although ext4_new_inode() *used* to also use atomic
> > bitops for synchronization, commit
> > 393418676a7602e1d7d3f6e560159c65c8cbd50e changed this to use
> > the sb_bgl_lock, so that we could also synchronize against
> > read_inode_bitmap and initialization of uninit inode tables.
> >
> > However, that change left ext4_free_inode using atomic bitops,
> > which I think leaves no synchronization between setting &
> > unsetting bits in the inode table.
> >
> > The below patch fixes it for me, although I wonder if we're
> > getting at all heavy-handed with this spinlock...
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Added to the ext4 patch queue. I will push this to Linus after I do a
bit of testing.
- Ted
next prev parent reply other threads:[~2009-03-05 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 4:38 [PATCH] fix ext4_free_inode vs. ext4_claim_inode race Eric Sandeen
2009-03-04 19:06 ` Aneesh Kumar K.V
2009-03-05 0:06 ` Theodore Tso [this message]
2009-03-04 23:11 ` Eric Sandeen
2009-03-05 4:03 ` Aneesh Kumar K.V
2009-03-05 4:21 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090305000603.GA30748@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).