* [PATCH] blkid: recognize ext4(dev) without journal
@ 2009-02-25 5:17 Eric Sandeen
2009-03-08 23:22 ` Theodore Tso
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2009-02-25 5:17 UTC (permalink / raw)
To: ext4 development
ext4/ext4dev no longer require a journal.
w/o this blkid doesn't recognize after:
# mkfs.ext4 /dev/blah
# tune2fs -O ^has_journal
# blkid /dev/blah
We still must have one ext3-incompat-feature to flag
as ext4(dev) so we shouldn't ever mis-recognize it.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
Index: e2fsprogs/lib/blkid/probe.c
===================================================================
--- e2fsprogs.orig/lib/blkid/probe.c
+++ e2fsprogs/lib/blkid/probe.c
@@ -281,11 +281,6 @@ static int probe_ext4dev(struct blkid_pr
EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)
return -BLKID_ERR_PARAM;
- /* ext4dev requires a journal */
- if (!(blkid_le32(es->s_feature_compat) &
- EXT3_FEATURE_COMPAT_HAS_JOURNAL))
- return -BLKID_ERR_PARAM;
-
/*
* If the filesystem is marked as OK for use by in-development
* filesystem code, but ext4dev is not supported, and ext4 is,
@@ -317,11 +312,6 @@ static int probe_ext4(struct blkid_probe
EXT3_FEATURE_INCOMPAT_JOURNAL_DEV)
return -BLKID_ERR_PARAM;
- /* ext4 requires journal */
- if (!(blkid_le32(es->s_feature_compat) &
- EXT3_FEATURE_COMPAT_HAS_JOURNAL))
- return -BLKID_ERR_PARAM;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] blkid: recognize ext4(dev) without journal
2009-02-25 5:17 [PATCH] blkid: recognize ext4(dev) without journal Eric Sandeen
@ 2009-03-08 23:22 ` Theodore Tso
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Tso @ 2009-03-08 23:22 UTC (permalink / raw)
To: Eric Sandeen; +Cc: ext4 development
On Tue, Feb 24, 2009 at 11:17:54PM -0600, Eric Sandeen wrote:
> ext4/ext4dev no longer require a journal.
>
> w/o this blkid doesn't recognize after:
>
> # mkfs.ext4 /dev/blah
> # tune2fs -O ^has_journal
> # blkid /dev/blah
>
> We still must have one ext3-incompat-feature to flag
> as ext4(dev) so we shouldn't ever mis-recognize it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied to the e2fsprogs git tree.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-09 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 5:17 [PATCH] blkid: recognize ext4(dev) without journal Eric Sandeen
2009-03-08 23:22 ` Theodore Tso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).